Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 164173: Cosmetic fixes to clobber_generated_headers.py:... (Closed)

Created:
11 years, 4 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Cosmetic fixes to clobber_generated_headers.py: Only try to remove a generated header file if it exists. Only report "Clobbered" if we actually removed something. Print the actual system error if the removal fails. Print the error message on stderr, not stdout. Normalize the header file path name. BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M build/win/clobber_generated_headers.py View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sgk
Suggested changes to the new clobber_generated_headers.py hook's reporting: basically, quieter about normal operation.
11 years, 4 months ago (2009-08-07 19:58:42 UTC) #1
Paweł Hajdan Jr.
On 2009/08/07 19:58:42, sgk wrote: > Suggested changes to the new clobber_generated_headers.py hook's reporting: > ...
11 years, 4 months ago (2009-08-07 20:01:51 UTC) #2
sgk
If you're working on more changes, feel free to fold any of this in as ...
11 years, 4 months ago (2009-08-07 20:07:13 UTC) #3
Paweł Hajdan Jr.
11 years, 4 months ago (2009-08-19 18:14:04 UTC) #4
LGTM

People are so annoyed about these warnings, and the script seems to work fine.
Please commit, and thanks for the change.

Powered by Google App Engine
This is Rietveld 408576698