Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 164136: Change the SpilledScope scope and ...AndSpill functions on ARM so that... (Closed)

Created:
11 years, 4 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Change the SpilledScope scope and ...AndSpill functions on ARM so that they do nothing. The frame is currently always spilled, so they were not doing anything useful. The call sites have been left alone to mark where spills will eventually be needed if we begin doing register allocation on ARM. Committed: http://code.google.com/p/v8/source/detail?r=2644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -97 lines) Patch
M src/arm/codegen-arm.h View 4 chunks +9 lines, -18 lines 0 comments Download
M src/arm/codegen-arm.cc View 9 chunks +1 line, -65 lines 0 comments Download
M src/arm/codegen-arm-inl.h View 1 chunk +31 lines, -0 lines 0 comments Download
M src/arm/virtual-frame-arm.h View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 4 months ago (2009-08-07 07:54:22 UTC) #1
Erik Corry
11 years, 4 months ago (2009-08-07 08:13:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698