Issue 164123: Linux: support mirrored charactors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164123: Linux: support mirrored charactors (Closed)

Created:
11 years, 4 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: support mirrored charactors Currently, when Harfbuzz requests a mirror charactor we just abort. This patch adds the Unicode tables required to support mirroring. BUG=17563

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1034 lines, -2 lines)			Patch
M	third_party/harfbuzz/contrib/harfbuzz-unicode.c	View	2 chunks	+23 lines, -2 lines	1 comment	Download
A	third_party/harfbuzz/contrib/tables/BidiMirroring.txt	View	1 chunk	+588 lines, -0 lines	0 comments	Download
A	third_party/harfbuzz/contrib/tables/mirroring-parse.py	View	1 chunk	+44 lines, -0 lines	1 comment	Download
A	third_party/harfbuzz/contrib/tables/mirroring-properties.h	View	1 chunk	+379 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 4 months ago (2009-08-07 19:57:06 UTC) #3

LGTM

http://codereview.chromium.org/164123/diff/1/2
File third_party/harfbuzz/contrib/harfbuzz-unicode.c (right):

http://codereview.chromium.org/164123/diff/1/2#newcode11
Line 11: #include "tables/mirroring-properties.h"
Nit: Should these headers be sorted or is this coming from upstream?

http://codereview.chromium.org/164123/diff/1/4
File third_party/harfbuzz/contrib/tables/mirroring-parse.py (right):

http://codereview.chromium.org/164123/diff/1/4#newcode3
Line 3: # http://www.unicode.org/Public/UNIDATA/auxiliary/BidiMirroring.txt
Nit: Can you add a comment explaining what this does and what output file it
generates (and the need to check in said generated file).

Expand Messages | Collapse Messages