Issue 164115: Treat certificate signatures using weak signature algorithms...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164115: Treat certificate signatures using weak signature algorithms... (Closed)

Created:
11 years, 4 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Mark Larson, Chris Evans

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Treat certificate signatures using weak signature algorithms as invalid. R=cevans,mal BUG=http://crbug.com/18725 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22709

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	net/base/x509_certificate_win.cc	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

http://codereview.chromium.org/164115/diff/1/2 File net/base/x509_certificate_win.cc (right): http://codereview.chromium.org/164115/diff/1/2#newcode469 Line 469: GetCertChainInfo(chain_context, verify_result); This function walks the certificate chain ...

11 years, 4 months ago (2009-08-07 00:13:39 UTC) #1

Chris Evans

LGTM The filename ends in _win.cc - do we need corresponding fixes for the Linux ...

11 years, 4 months ago (2009-08-07 00:33:08 UTC) #2

wtc

11 years, 4 months ago (2009-08-07 01:17:48 UTC) #3

We don't need a corresponding fix for the Linux port because the
new NSS release (3.12.3 and 3.12.3.1) has the fix.  See
"NSS_ALLOW_WEAK_SIGNATURE_ALG" in
http://www.mozilla.org/projects/security/pki/nss/nss-3.12.3/nss-3.12.3-releas...

I don't know if the system certificate library on the Mac has been
patched...

Expand Messages | Collapse Messages