Issue 164092: Correctly handle extensions width in the GTK extension shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164092: Correctly handle extensions width in the GTK extension shelf. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Correctly handle extensions width in the GTK extension shelf. Also make the method name used on Windows shorter and more obvious. TEST=none http://crbug.com/16759 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22672

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -6 lines)			Patch
M	chrome/browser/extensions/extension_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/extension_shelf_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/extension_view_gtk.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/extension_view_gtk.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/extensions/extension_view.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

rafaelw

11 years, 4 months ago (2009-08-06 21:31:43 UTC) #2

LGTM on everything except usage of gtk api (I have no idea about that =-).