Issue 164091: Report apt-get failures in install-build-deps.sh...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164091: Report apt-get failures in install-build-deps.sh... (Closed)

Created:
11 years, 4 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Report apt-get failures in install-build-deps.sh Patch from gmatht, originally reviewed at http://codereview.chromium.org/160630 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22665

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -14 lines)			Patch
	M	build/install-build-deps.sh	View		2 chunks	+35 lines, -14 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

11 years, 4 months ago (2009-08-07 20:01:02 UTC) #1

http://codereview.chromium.org/164091/diff/1/2
File build/install-build-deps.sh (right):

http://codereview.chromium.org/164091/diff/1/2#newcode251
Line 251: EOF
Actually that needed to be a tab. When it's 8 spaces, bash doesn't detect the
EOF. I'll fix this soon.

Expand Messages | Collapse Messages