Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: src/codegen-arm.cc

Issue 16409: Inline array loads in loops directly in the code instead of always... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3264 matching lines...) Expand 10 before | Expand all | Expand 10 after
3275 } else { 3275 } else {
3276 __ Call(ic, RelocInfo::CODE_TARGET); 3276 __ Call(ic, RelocInfo::CODE_TARGET);
3277 } 3277 }
3278 frame->Push(r0); 3278 frame->Push(r0);
3279 break; 3279 break;
3280 } 3280 }
3281 3281
3282 case KEYED: { 3282 case KEYED: {
3283 // TODO(1241834): Make sure that this it is safe to ignore the 3283 // TODO(1241834): Make sure that this it is safe to ignore the
3284 // distinction between expressions in a typeof and not in a typeof. 3284 // distinction between expressions in a typeof and not in a typeof.
3285
3286 // TODO(number here): Implement inlined version of array
3287 // indexing once loop nesting is properly tracked on ARM.
3285 Comment cmnt(masm, "[ Load from keyed Property"); 3288 Comment cmnt(masm, "[ Load from keyed Property");
3286 ASSERT(property != NULL); 3289 ASSERT(property != NULL);
3287 Handle<Code> ic(Builtins::builtin(Builtins::KeyedLoadIC_Initialize)); 3290 Handle<Code> ic(Builtins::builtin(Builtins::KeyedLoadIC_Initialize));
3288 3291
3289 Variable* var = expression_->AsVariableProxy()->AsVariable(); 3292 Variable* var = expression_->AsVariableProxy()->AsVariable();
3290 if (var != NULL) { 3293 if (var != NULL) {
3291 ASSERT(var->is_global()); 3294 ASSERT(var->is_global());
3292 __ Call(ic, RelocInfo::CODE_TARGET_CONTEXT); 3295 __ Call(ic, RelocInfo::CODE_TARGET_CONTEXT);
3293 } else { 3296 } else {
3294 __ Call(ic, RelocInfo::CODE_TARGET); 3297 __ Call(ic, RelocInfo::CODE_TARGET);
(...skipping 1037 matching lines...) Expand 10 before | Expand all | Expand 10 after
4332 __ mov(r2, Operand(0)); 4335 __ mov(r2, Operand(0));
4333 __ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION); 4336 __ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION);
4334 __ Jump(Handle<Code>(Builtins::builtin(Builtins::ArgumentsAdaptorTrampoline)), 4337 __ Jump(Handle<Code>(Builtins::builtin(Builtins::ArgumentsAdaptorTrampoline)),
4335 RelocInfo::CODE_TARGET); 4338 RelocInfo::CODE_TARGET);
4336 } 4339 }
4337 4340
4338 4341
4339 #undef __ 4342 #undef __
4340 4343
4341 } } // namespace v8::internal 4344 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698