Add all modified files to new changelists by default.

gcl.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Wrapper script around Rietveld's upload.py that groups files into
 # changelists.
 
 import getpass
 import os
@@ skipping 288 matching lines @@
     return [file[1] for file in self._files]
 
   def GetFiles(self):
     """Returns the list of files included in this change with their status."""
     return self._files
 
   def GetLocalRoot(self):
     """Returns the local repository checkout root directory."""
     return self._local_root
 
+  def Exists(self):
+    """Returns True if this change already exists (i.e., is not new)."""
+    return (self.issue or self.description or self._files)
+
   def _NonDeletedFileList(self):
     """Returns a list of files in this change, not including deleted files."""
     return [file[1] for file in self.GetFiles()
             if not file[0].startswith("D")]
 
   def _AddedFileList(self):
     """Returns a list of files added in this change."""
     return [file[1] for file in self.GetFiles() if file[0].startswith("A")]
 
   def Save(self):
@@ skipping 652 matching lines @@
       else:
         ErrorExit("Error getting the description from Rietveld: " + err)
   else:
     if override_description:
       description = override_description
     else:
       description = change_info.description
 
   other_files = GetFilesNotInCL()
 
-  #Edited files will have a letter for the first character in a string.
-  #This regex looks for the presence of that character.
+  # Edited files (as opposed to files with only changed properties) will have
+  # a letter for the first character in the status string.
   file_re = re.compile(r"^[a-z].+\Z", re.IGNORECASE)
-  affected_files = filter(lambda x: file_re.match(x[0]), other_files)
-  unaffected_files = filter(lambda x: not file_re.match(x[0]), other_files)
+  affected_files = [x for x in other_files if file_re.match(x[0])]

[M-A Ruel, 2009/08/07 01:01:30]

Hey, you are fixing my abuse of filter()!

+  unaffected_files = [x for x in other_files if not file_re.match(x[0])]
 
   separator1 = ("\n---All lines above this line become the description.\n"
                 "---Repository Root: " + change_info.GetLocalRoot() + "\n"
                 "---Paths in this changelist (" + change_info.name + "):\n")
   separator2 = "\n\n---Paths modified but not in any changelist:\n\n"
   text = (description + separator1 + '\n' +
-          '\n'.join([f[0] + f[1] for f in change_info.GetFiles()]) +
-          separator2 +
-          '\n'.join([f[0] + f[1] for f in affected_files]) + '\n' +
-          '\n'.join([f[0] + f[1] for f in unaffected_files]) + '\n')
+          '\n'.join([f[0] + f[1] for f in change_info.GetFiles()]))
+
+  if change_info.Exists():
+    text += (separator2 +
+            '\n'.join([f[0] + f[1] for f in affected_files]) + '\n')
+  else:
+    text += ('\n'.join([f[0] + f[1] for f in affected_files]) + '\n' +
+            separator2)
+  text += '\n'.join([f[0] + f[1] for f in unaffected_files]) + '\n'
 
   handle, filename = tempfile.mkstemp(text=True)
   os.write(handle, text)
   os.close(handle)
 
   os.system(GetEditor() + " " + filename)
 
   result = ReadFile(filename)
   os.remove(filename)
 
@@ skipping 221 matching lines @@
     # the files. This allows commands such as 'gcl diff xxx' to work.
     args =["svn", command]
     root = GetRepositoryRoot()
     args.extend([os.path.join(root, x) for x in change_info.GetFileNames()])
     RunShell(args, True)
   return 0
 
 
 if __name__ == "__main__":
   sys.exit(main())