Issue 164084: Add all modified files to new changelists by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164084: Add all modified files to new changelists by default. (Closed)

Created:
11 years, 4 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Add all modified files to new changelists by default. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22800

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	gcl.py	View	1 2	2 chunks	+17 lines, -8 lines	1 comment	Download
	M	tests/gcl_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 4 months ago (2009-08-07 01:01:30 UTC) #2

lgtm

http://codereview.chromium.org/164084/diff/1002/1003
File gcl.py (right):

http://codereview.chromium.org/164084/diff/1002/1003#newcode988
Line 988: affected_files = [x for x in other_files if file_re.match(x[0])]
Hey, you are fixing my abuse of filter()!

Expand Messages | Collapse Messages