Issue 164056: X64: Implement inline trigonometric operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164056: X64: Implement inline trigonometric operations. (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Implement inline trigonometric operations. Committed: http://code.google.com/p/v8/source/detail?r=2638

Patch Set 1 #

Total comments: 3

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -53 lines)			Patch
	M	src/x64/codegen-x64.cc	View		5 chunks	+121 lines, -53 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 4 months ago (2009-08-06 12:49:39 UTC) #2

LGTM

http://codereview.chromium.org/164056/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/164056/diff/1/2#newcode178
Line 178: static void LoadFloatOperand(MacroAssembler* masm, Register scratch);
Add an empty line after declarations.

http://codereview.chromium.org/164056/diff/1/2#newcode214
Line 214: // Test if operands are smi or number objects (fp). Requirements:
Unclear whether it tests (is smi or is heapnumber) or just whether it is a
heapnumber.

http://codereview.chromium.org/164056/diff/1/2#newcode3618
Line 3618: __ sahf();
Using sahf is theoretically unsafe (not supported on some early x64 chips).

Expand Messages | Collapse Messages