Issue 164054: X64: Optimize MOD operator by a constant power of 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164054: X64: Optimize MOD operator by a constant power of 2. (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Optimize MOD operator by a constant power of 2. Committed: http://code.google.com/p/v8/source/detail?r=2634

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -47 lines)			Patch
	M	src/x64/codegen-x64.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View	1	6 chunks	+118 lines, -47 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 4 months ago (2009-08-06 11:46:19 UTC) #2

LGTM

http://codereview.chromium.org/164054/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/164054/diff/1/2#newcode4990
Line 4990: break;  // This break only applies if the condition of the if is
true.
Somewhat tautologous.  Perhaps "This break ... if the dividend was a power of 2"

Expand Messages | Collapse Messages