Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 164053: Irregexp-ia32 internal call strategy changed. (Closed)

Created:
11 years, 4 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
sandholm, Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Irregexp-ia32 internal call strategy changed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M src/ia32/regexp-macro-assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
Seems faster in some cases, slower in others. Is it worth it? Could it be ...
11 years, 4 months ago (2009-08-06 10:42:23 UTC) #1
Erik Corry
LGTM more for the code size improvement than any performance changes.
11 years, 4 months ago (2009-08-06 11:11:25 UTC) #2
sandholm
10 years, 9 months ago (2010-03-22 09:53:38 UTC) #3
On 2009/08/06 11:11:25, Erik Corry wrote:
> LGTM more for the code size improvement than any performance changes.

What are the code size improvements?
This is a clear performance regression.
Please revert, if possible.

Powered by Google App Engine
This is Rietveld 408576698