Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/extensions/extension_host.cc

Issue 164039: Add module-level permissions to extensions. (Closed)
Patch Set: final nits Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_host.h" 5 #include "chrome/browser/extensions/extension_host.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "chrome/browser/browser.h" 10 #include "chrome/browser/browser.h"
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 // NOTE(rafaelw): This can return NULL in some circumstances. In particular, 379 // NOTE(rafaelw): This can return NULL in some circumstances. In particular,
380 // a toolstrip or background_page onload chrome.tabs api call can make it 380 // a toolstrip or background_page onload chrome.tabs api call can make it
381 // into here before the browser is sufficiently initialized to return here. 381 // into here before the browser is sufficiently initialized to return here.
382 // A similar situation may arise during shutdown. 382 // A similar situation may arise during shutdown.
383 // TODO(rafaelw): Delay creation of background_page until the browser 383 // TODO(rafaelw): Delay creation of background_page until the browser
384 // is available. http://code.google.com/p/chromium/issues/detail?id=13284 384 // is available. http://code.google.com/p/chromium/issues/detail?id=13284
385 return browser; 385 return browser;
386 } 386 }
387 387
388 void ExtensionHost::RenderViewCreated(RenderViewHost* render_view_host) { 388 void ExtensionHost::RenderViewCreated(RenderViewHost* render_view_host) {
389 // TODO(mpcomplete): This is duplicated in DidNavigate, which means that
390 // we'll create 2 EFDs for the first navigation. We should try to find a
391 // better way to unify them.
392 // See http://code.google.com/p/chromium/issues/detail?id=18240
393 extension_function_dispatcher_.reset(
394 new ExtensionFunctionDispatcher(render_view_host, this, url_));
389 } 395 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_function_dispatcher.cc ('k') | chrome/browser/extensions/extensions_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698