Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: third_party/sqlite/README.chromium

Issue 1638019: Applying fts2.patch to fts3. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | third_party/sqlite/ext/fts3/fts3.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name: SQLite 1 Name: SQLite
2 URL: http://sqlite.org/ 2 URL: http://sqlite.org/
3 3
4 Instructions for importing a new release of SQLite from sqlite.org. 4 Instructions for importing a new release of SQLite from sqlite.org.
5 5
6 Note: our current base version is 3.6.18. 6 Note: our current base version is 3.6.18.
7 7
8 First, you need to be on Linux. 8 First, you need to be on Linux.
9 9
10 # Determine the versions of the release you want and the release we currently 10 # Determine the versions of the release you want and the release we currently
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 For reference, all of our local patches are also kept as .patch files in the 50 For reference, all of our local patches are also kept as .patch files in the
51 sqlite directory. Here is a list of the patches, in the order they should be 51 sqlite directory. Here is a list of the patches, in the order they should be
52 applied to a vanilla SQLite (of the version we currently have) to get, in 52 applied to a vanilla SQLite (of the version we currently have) to get, in
53 principle, exactly what is checked in: 53 principle, exactly what is checked in:
54 54
55 misc.patch 55 misc.patch
56 preload-cache.patch 56 preload-cache.patch
57 safe-tolower.patch 57 safe-tolower.patch
58 sqlite-poison.patch 58 sqlite-poison.patch
59 fts2.patch 59 fts2.patch
60 fts3.patch
60 icu-regexp.patch 61 icu-regexp.patch
61 attach-integer.patch 62 attach-integer.patch
62 63
63 So, e.g. you could do this to apply all our patches to vanilla SQLite: 64 So, e.g. you could do this to apply all our patches to vanilla SQLite:
64 65
65 cd sqlite-$LATEST 66 cd sqlite-$LATEST
66 patch -p0 < ../sqlite/misc.patch 67 patch -p0 < ../sqlite/misc.patch
67 patch -p0 < ../sqlite/preload-cache.patch 68 patch -p0 < ../sqlite/preload-cache.patch
68 patch -p0 < ../sqlite/safe-tolower.patch 69 patch -p0 < ../sqlite/safe-tolower.patch
69 patch -p0 < ../sqlite/sqlite-poison.patch 70 patch -p0 < ../sqlite/sqlite-poison.patch
70 patch -p0 < ../sqlite/fts2.patch 71 patch -p0 < ../sqlite/fts2.patch
72 patch -p0 < ../sqlite/fts3.patch
71 patch -p0 < ../sqlite/icu-regexp.patch 73 patch -p0 < ../sqlite/icu-regexp.patch
72 patch -p0 < ../sqlite/attach-integer.patch 74 patch -p0 < ../sqlite/attach-integer.patch
73 75
74 This will only be the case if all changes we make also update the corresponding 76 This will only be the case if all changes we make also update the corresponding
75 patch files. Therefore please remember to do that whenever you make a change! 77 patch files. Therefore please remember to do that whenever you make a change!
76 78
77 Descriptions of the changes we've made can be found at the bottom of this file. 79 Descriptions of the changes we've made can be found at the bottom of this file.
78 80
79 -------------------------------------------- 81 --------------------------------------------
80 82
(...skipping 14 matching lines...) Expand all
95 # However, the current situation on my corp Linux Ubuntu 8.04 machine, with 97 # However, the current situation on my corp Linux Ubuntu 8.04 machine, with
96 # test run on a locally mounted directory, is the failure of: 98 # test run on a locally mounted directory, is the failure of:
97 # "rollback-2.3", "tkt3457-1.4" 99 # "rollback-2.3", "tkt3457-1.4"
98 # I do not know why, but it is not related to our fts2.c changes -- I backed 100 # I do not know why, but it is not related to our fts2.c changes -- I backed
99 # them out to check. 101 # them out to check.
100 102
101 Chris Evans <cevans@google.com>, Oct 1, 2009 103 Chris Evans <cevans@google.com>, Oct 1, 2009
102 104
103 -------------------------------------------- 105 --------------------------------------------
104 106
105 As of Dec 16, 2009, these are our changes from sqlite_vendor: 107 As of May 07, 2010, these are our changes from sqlite_vendor:
106 108
107 - A fix for a crash passing an integer expression to ATTACH / DETACH. See 109 - A fix for a crash passing an integer expression to ATTACH / DETACH. See
108 attach-integer.patch 110 attach-integer.patch
109 - A fix for a crash mis-calling the REGEXP() function of the ICU extension. 111 - A fix for a crash mis-calling the REGEXP() function of the ICU extension.
110 See icu-regexp.patch 112 See icu-regexp.patch
111 - A large number of fts2 robustness fixes against corrupt data in its metadata 113 - A large number of fts2 robustness fixes against corrupt data in its metadata
112 tables. 114 tables.
113 - fts2.c disables fts2_tokenizer(). 115 - fts2.c disables fts2_tokenizer().
116 - fts3.c disables fts3_tokenizer().
114 - sqlite3Poison() in src/btree.c. 117 - sqlite3Poison() in src/btree.c.
115 - Tweak to SQLITE_EXTENSION_INIT* in sqlite3ext.h. 118 - Tweak to SQLITE_EXTENSION_INIT* in sqlite3ext.h.
116 - That implied a change in src/test_autoext.c for testing. 119 - That implied a change in src/test_autoext.c for testing.
117 - Added fts.test and fts1.test in tests, modified quick.test. 120 - Added fts.test and fts1.test in tests, modified quick.test.
118 - src/os_symbian.cc. 121 - src/os_symbian.cc.
119 - Modifications to Makefile.linux-gcc and main.mk for compiling 122 - Modifications to Makefile.linux-gcc and main.mk for compiling
120 SQLite tests. 123 SQLite tests.
121 - Compile warning (cast to void* for sqlite3_free) fixed in func.c. 124 - Compile warning (cast to void* for sqlite3_free) fixed in func.c.
122 - Avoid using tolower() in fts code which causes problem in some locales, see: 125 - Avoid using tolower() in fts code which causes problem in some locales, see:
123 safe-tolower.patch 126 safe-tolower.patch
(...skipping 10 matching lines...) Expand all
134 fts2_tokenizer.c and icu.c. Without this #define, the calls in 137 fts2_tokenizer.c and icu.c. Without this #define, the calls in
135 fts2_tokenizer.c try to go through some pointer to the sqlite API instead 138 fts2_tokenizer.c try to go through some pointer to the sqlite API instead
136 of calling the functions directly (to work as a loadable module), but then 139 of calling the functions directly (to work as a loadable module), but then
137 crash (because the other files never initialize that loadable module 140 crash (because the other files never initialize that loadable module
138 support). As a hack I #defined it in these files, but it'd be nice to 141 support). As a hack I #defined it in these files, but it'd be nice to
139 figure out what really ought to happen here (perhaps this file is new and 142 figure out what really ought to happen here (perhaps this file is new and
140 hasn't been tested to verify it works right). Update: Seems this is an 143 hasn't been tested to verify it works right). Update: Seems this is an
141 issue we get because we're using fts2 instead of fts3. 144 issue we get because we're using fts2 instead of fts3.
142 - shell_icu_win.c and shell_icu_linux.c are Chrome-specific files used to load 145 - shell_icu_win.c and shell_icu_linux.c are Chrome-specific files used to load
143 our ICU data. shell.c has been modifed to call into these files. 146 our ICU data. shell.c has been modifed to call into these files.
144 - fts2_icu.c has a critical bug. U8_NEXT is used over a UTF-16 string. It's 147 - fts2_icu.c and fts3_icu.c have a critical bug. U8_NEXT is used over
145 rep$ by U16_NEXT (jungshik) 148 a UTF-16 string. It's rep$ by U16_NEXT (jungshik)
146 - Added a new function sqlite3Preload we use to prime the database cache. It 149 - Added a new function sqlite3Preload we use to prime the database cache. It
147 allows much faster performance by reading the file in one contiguous 150 allows much faster performance by reading the file in one contiguous
148 operation rather than bringing it in organically, which involves a lot of 151 operation rather than bringing it in organically, which involves a lot of
149 seeking. This change also required sqlite3PcacheGetCachesize to be compiled 152 seeking. This change also required sqlite3PcacheGetCachesize to be compiled
150 even outside SQLITE_TEST. 153 even outside SQLITE_TEST.
151 - Added a new function chromium_sqlite3_initialize_win_sqlite3_file() 154 - Added a new function chromium_sqlite3_initialize_win_sqlite3_file()
152 at the end of os_win.c. It allows the Windows-specific Chromium VFS 155 at the end of os_win.c. It allows the Windows-specific Chromium VFS
153 to reuse most of the win32 SQLite VFS. 156 to reuse most of the win32 SQLite VFS.
154 - Added a new function 157 - Added a new function
155 chromium_sqlite3_initialize_unix_sqlite3_file() and made 158 chromium_sqlite3_initialize_unix_sqlite3_file() and made
156 fillInUnixFile() non-static in os_unix.c. It allows the 159 fillInUnixFile() non-static in os_unix.c. It allows the
157 Linux-specific Chromium VFS to reuse most of the unix SQLite VFS. 160 Linux-specific Chromium VFS to reuse most of the unix SQLite VFS.
158 - Exposed three functions that deal with unused file descriptors in 161 - Exposed three functions that deal with unused file descriptors in
159 os_unix.c, to allow Chromium's Posix VFS implementation in 162 os_unix.c, to allow Chromium's Posix VFS implementation in
160 WebKit/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp 163 WebKit/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp
161 to correctly implement the "unused file descriptors" logic in the 164 to correctly implement the "unused file descriptors" logic in the
162 xDlOpen() method. The new functions are 165 xDlOpen() method. The new functions are
163 chromium_sqlite3_get_reusable_file_handle(), 166 chromium_sqlite3_get_reusable_file_handle(),
164 chromium_sqlite3_update_reusable_file_handle() and 167 chromium_sqlite3_update_reusable_file_handle() and
165 chromium_sqlite3_destroy_reusable_file_handle(). Also, added the 168 chromium_sqlite3_destroy_reusable_file_handle(). Also, added the
166 chromium_sqlite3_fill_in_unix_sqlite3_file() function that calls 169 chromium_sqlite3_fill_in_unix_sqlite3_file() function that calls
167 fillInUnixFile(), which will be made static again as soon as a 170 fillInUnixFile(), which will be made static again as soon as a
168 WebKit patch using the new function lands. 171 WebKit patch using the new function lands.
OLDNEW
« no previous file with comments | « no previous file | third_party/sqlite/ext/fts3/fts3.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698