Issue 1638006: One less dependent load in InvokeBuiltin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1638006: One less dependent load in InvokeBuiltin. (Closed)

Created:
10 years, 8 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

One less dependent load in InvokeBuiltin. Committed: http://code.google.com/p/v8/source/detail?r=4423

Patch Set 1 #

Patch Set 2 : . #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -32 lines)			Patch
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+12 lines, -8 lines	0 comments	Download
M	src/bootstrapper.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+11 lines, -9 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+18 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+17 lines, -3 lines	0 comments	Download
M	src/serialize.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		1 chunk	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 8 months ago (2010-04-14 19:00:24 UTC) #3

Change to serialize.h looks good too.

We have to be absolutely sure that the code that is called is referenced from
the function that is pushed otherwise the stack cooking and uncooking fails.

Expand Messages | Collapse Messages