Issue 1637015: Add stack alignment check to ia32 and x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1637015: Add stack alignment check to ia32 and x64 (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add stack alignment check to ia32 and x64 The stack is now checked for proper alignment before calling into C code when the flag --debug-code is turned on. Committed: http://code.google.com/p/v8/source/detail?r=4428

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -2 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	src/platform-linux.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/1637015/diff/1/4 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/1637015/diff/1/4#newcode1536 src/ia32/macro-assembler-ia32.cc:1536: double space! http://codereview.chromium.org/1637015/diff/1/2 File src/platform-linux.cc (right): http://codereview.chromium.org/1637015/diff/1/2#newcode162 src/platform-linux.cc:162: ...

10 years, 8 months ago (2010-04-15 12:32:47 UTC) #2

Søren Thygesen Gjesse

10 years, 8 months ago (2010-04-15 12:38:06 UTC) #3

http://codereview.chromium.org/1637015/diff/1/4
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/1637015/diff/1/4#newcode1536
src/ia32/macro-assembler-ia32.cc:1536: 
On 2010/04/15 12:32:47, Erik Corry wrote:
> double space!

Done.

Expand Messages | Collapse Messages