Issue 1637009: Create const ints for int8_t and int32_t in jmp assembler (making win64 build...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1637009: Create const ints for int8_t and int32_t in jmp assembler (making win64 build... (Closed)

Created:
10 years, 8 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Create const ints for int8_t and int32_t in jmp assembler (making win64 build happy) Committed: http://code.google.com/p/v8/source/detail?r=4408

Patch Set 3 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/x64/assembler-x64.cc	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/1637009/diff/1/2 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/1637009/diff/1/2#newcode1143 src/x64/assembler-x64.cc:1143: const int long_size = sizeof(int32_t); Two spaces before ...

10 years, 8 months ago (2010-04-14 08:51:06 UTC) #2

Rico

10 years, 8 months ago (2010-04-14 08:53:47 UTC) #3

http://codereview.chromium.org/1637009/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/1637009/diff/1/2#newcode1143
src/x64/assembler-x64.cc:1143: const int long_size  = sizeof(int32_t);
On 2010/04/14 08:51:06, Søren Gjesse wrote:
> Two spaces before =.

Done.

http://codereview.chromium.org/1637009/diff/1/2#newcode1144
src/x64/assembler-x64.cc:1144: int offs = L->pos() - pc_offset()-1;
On 2010/04/14 08:51:06, Søren Gjesse wrote:
> Spaces arround binary operation (-).

Done.

Expand Messages | Collapse Messages

Issue 1637009: Create const ints for int8_t and int32_t in jmp assembler (making win64 build... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages