Allow new CPU profiling subsystem to coexist nicely with the old one.

Allow new CPU profiling subsystem to coexist nicely with the old one.

This is to make possible enabling usage of the new profiling subsystem
in Chromium without much hassle. The idea is pretty simple: unless the
new profiling API is used, all works as usual, as soon as Chromium
starts to use the new API, it will work too.

Committed: http://code.google.com/p/v8/source/detail?r=4382

[Søren Thygesen Gjesse, 2010-04-12 06:56:28]

LGTM

Will the end goal to totally remove the need for ENABLE_CPP_PROFILES_PROCESSOR?

http://codereview.chromium.org/1635005/diff/2001/3002
File src/cpu-profiler-inl.h (right):

http://codereview.chromium.org/1635005/diff/2001/3002#newcode64
src/cpu-profiler-inl.h:64: result->filler = 1;  // !=
SamplingCircularQueue::kClear.
Please add 

ASSERT(result->filler = != SamplingCircularQueue::kClear);

[mnaganov (inactive), 2010-04-12 07:17:45]

Thanks!

Yes, it is now possible to merge CPP_PROFILES_PROCESSOR defines with
LOGGING_AND_PROFILING. I'm leaving them mainly for two reasons:
 - explicitly highlighting the new code for other developers, and; 
 - being able to cloak the new code in case if something goes wrong.

http://codereview.chromium.org/1635005/diff/2001/3002
File src/cpu-profiler-inl.h (right):

http://codereview.chromium.org/1635005/diff/2001/3002#newcode64
src/cpu-profiler-inl.h:64: result->filler = 1;  // !=
SamplingCircularQueue::kClear.
On 2010/04/12 06:56:28, Søren Gjesse wrote:
> Please add 
> 
> ASSERT(result->filler = != SamplingCircularQueue::kClear);

Done.