Make not sucking at regexp the default...

Make not sucking at regexp the default
(remove V8_NATIVE_REGEXP flag, add
V8_INTERPRETED_REGEXP flag).

Committed: http://code.google.com/p/v8/source/detail?r=4443

[Mads Ager (chromium), 2010-04-08 09:06:19]

Please cleanup the #ifdef comments. Other than that LGTM.

http://codereview.chromium.org/1635001/diff/1/13
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1635001/diff/1/13#newcode10930
src/ia32/codegen-ia32.cc:10930: #endif  // ndef V8_INTERPRETED_REGEXP
This is ending an ifdef not an ifndef.

http://codereview.chromium.org/1635001/diff/1/14
File src/ia32/regexp-macro-assembler-ia32.h (right):

http://codereview.chromium.org/1635001/diff/1/14#newcode211
src/ia32/regexp-macro-assembler-ia32.h:211: #endif  // ndef
V8_INTERPRETED_REGEXP
Ditto.

http://codereview.chromium.org/1635001/diff/1/28
File src/jsregexp.cc (right):

http://codereview.chromium.org/1635001/diff/1/28#newcode368
src/jsregexp.cc:368: #endif  // !V8_INTERPRETED_REGEXP
Remove !.

http://codereview.chromium.org/1635001/diff/1/28#newcode436
src/jsregexp.cc:436: #endif  // def V8_INTERPRETED_REGEXP
ndef

The mix of def, ndef, and ! in these comments is a mess. Maybe we should clean
it up now that we have them all identified.

http://codereview.chromium.org/1635001/diff/1/28#newcode5252
src/jsregexp.cc:5252: #endif  // def V8_INTERPRETED_REGEXP
ndef

http://codereview.chromium.org/1635001/diff/1/21
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/1635001/diff/1/21#newcode7290
src/x64/codegen-x64.cc:7290: #endif  // ndef V8_INTERPRETED_REGEXP
def

http://codereview.chromium.org/1635001/diff/1/3
File test/cctest/test-regexp.cc (right):

http://codereview.chromium.org/1635001/diff/1/3#newcode56
test/cctest/test-regexp.cc:56: #endif  // ndef V8_INTERPRETED_REGEXP
def

http://codereview.chromium.org/1635001/diff/1/3#newcode1335
test/cctest/test-regexp.cc:1335: #endif  // def V8_INTERPRETED_REGEXP
ndef

[Erik Corry, 2010-04-08 09:07:51]

http://codereview.chromium.org/1635001/diff/1/13
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1635001/diff/1/13#newcode10930
src/ia32/codegen-ia32.cc:10930: #endif  // ndef V8_INTERPRETED_REGEXP
On 2010/04/08 09:06:19, Mads Ager wrote:
> This is ending an ifdef not an ifndef.

It's ending the else part of an ifdef, so in effect it is ending an ifndef.

[Erik Corry, 2010-04-19 19:25:08]

I tried to make the comments on endif and else more consistent removing the
'def' and 'ndef' and ! and just naming the variable that the endif related to. 
Also removed unused variable in the gyp file.

[Søren Thygesen Gjesse, 2010-04-19 19:59:12]

LGTM!

http://codereview.chromium.org/1635001/diff/23001/6018
File src/assembler.h (right):

http://codereview.chromium.org/1635001/diff/23001/6018#newcode459
src/assembler.h:459: #ifndef V8_INTERPRETED_REGEXP
Missing comment on related #endif?

http://codereview.chromium.org/1635001/diff/23001/6027
File src/heap.h (right):

http://codereview.chromium.org/1635001/diff/23001/6027#newcode114
src/heap.h:114: #if V8_TARGET_ARCH_ARM && !V8_INTERPRETED_REGEXP
Missing comment on #else and #endif, but I think thats fine here with them being
so close together.

http://codereview.chromium.org/1635001/diff/23001/6028
File src/jsregexp.cc (right):

http://codereview.chromium.org/1635001/diff/23001/6028#newcode242
src/jsregexp.cc:242: #endif
Add comment here or remove from #else

http://codereview.chromium.org/1635001/diff/23001/6021
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/1635001/diff/23001/6021#newcode7922
src/x64/codegen-x64.cc:7922: #endif
Comment here as well.

[Erik Corry, 2010-04-20 00:16:12]

I'm afraid I already committed on the strength of Mads'  LGTM.  I'll fix these
things in a different change.