Issue 1633018: devserver support for update images from buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1633018: devserver support for update images from buildbot. (Closed)

Created:
10 years, 8 months ago by seano

Modified:
9 years, 7 months ago

Reviewers:
petkov, rtc, Bill Richardson, ericli

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

devserver support for update images from buildbot. Remove implicit sudo from gpt partition packing scripts. Misc cleanup and fixes included.

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -5 lines)			Patch
M	src/platform/dev/autoupdate.py	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/platform/dev/devserver.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/scripts/emit_gpt_scripts.sh	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

ericli

You want ask someone familiar with gpt to review your gpt script change? otherwise LGTM. ...

10 years, 8 months ago (2010-04-16 20:40:01 UTC) #2

LGTM