Issue 1631018: Only put VM state entry if a symbolized stacktrace is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1631018: Only put VM state entry if a symbolized stacktrace is empty. (Closed)

Created:
10 years, 8 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Only put VM state entry if a symbolized stacktrace is empty. This makes more sense than putting "(program)" as the root of every stack trace in broswer mode. Committed: http://code.google.com/p/v8/source/detail?r=4430

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	src/profile-generator.cc	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/1631018/diff/1/2 File src/profile-generator.cc (right): http://codereview.chromium.org/1631018/diff/1/2#newcode565 src/profile-generator.cc:565: // If no frames were symbolized, the VM ...

10 years, 8 months ago (2010-04-15 12:47:17 UTC) #2

mnaganov (inactive)

10 years, 8 months ago (2010-04-15 14:11:50 UTC) #3

http://codereview.chromium.org/1631018/diff/1/2
File src/profile-generator.cc (right):

http://codereview.chromium.org/1631018/diff/1/2#newcode565
src/profile-generator.cc:565: // If no frames were symbolized, the VM state
entry in.
On 2010/04/15 12:47:18, Søren Gjesse wrote:
> This comment is broken.

Done.

http://codereview.chromium.org/1631018/diff/1/2#newcode567
src/profile-generator.cc:567: if (*e != NULL) goto skip;
On 2010/04/15 12:47:18, Søren Gjesse wrote:
> Please avoid using goto.

Done.

Expand Messages | Collapse Messages