Issue 1631015: Fix chrome os flakyness for test ExtensionApiTest.CaptureVisibleTab....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1631015: Fix chrome os flakyness for test ExtensionApiTest.CaptureVisibleTab.... (Closed)

Created:
10 years, 8 months ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix chrome os flakyness for test ExtensionApiTest.CaptureVisibleTab. While in the code, add tests for PNG capture, and make code test that the resulting image is the right color. BUG=41380 TEST=ExtensionApiTest.CaptureVisibleTab Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44681

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -53 lines)			Patch
M	chrome/browser/extensions/extension_tabs_apitest.cc	View	1 2 3 4 5	1 chunk	+1 line, -8 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/a.html	View	1 2 3 4 5	1 chunk	+0 lines, -5 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/b.html	View	1 2 3 4 5	1 chunk	+0 lines, -5 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/black.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/c.html	View	1 2 3 4 5	1 chunk	+0 lines, -5 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/red.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/tabs_util.js	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/test.js	View	1 2 3 4 5	2 chunks	+94 lines, -29 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/tabs/capture_visible_tab/white.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm. nice!

Expand Messages | Collapse Messages