Optimize the assembly code generated for Math.random()

src/x64/codegen-x64.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4063 matching lines @@
 }
 
 
 void CodeGenerator::GenerateRandomHeapNumber(
     ZoneList<Expression*>* args) {
   ASSERT(args->length() == 0);
   frame_->SpillAll();
 
   Label slow_allocate_heapnumber;
   Label heapnumber_allocated;
-  __ AllocateHeapNumber(rdi, rbx, &slow_allocate_heapnumber);
+  __ AllocateHeapNumber(rbx, rcx, &slow_allocate_heapnumber);
   __ jmp(&heapnumber_allocated);
 
   __ bind(&slow_allocate_heapnumber);
   // To allocate a heap number, and ensure that it is not a smi, we
   // call the runtime function FUnaryMinus on 0, returning the double
   // -0.0.  A new, distinct heap number is returned each time.
   __ Push(Smi::FromInt(0));
   __ CallRuntime(Runtime::kNumberUnaryMinus, 1);
-  __ movq(rdi, rax);
+  __ movq(rbx, rax);
 
   __ bind(&heapnumber_allocated);
 
-  // Put a random number into the heap number rdi using a C++ function.
-  // Return the heap number in rax.
-#ifdef _WIN64
-  __ movq(rcx, rdi);
-#else
-  // Callee-save in Microsoft 64-bit ABI, but not in AMD64 ABI.
-  __ push(rsi);
-#endif
-  __ PrepareCallCFunction(1);
-  __ CallCFunction(ExternalReference::fill_heap_number_with_random_function(),
-                   1);
-#ifndef _WIN64
-  // Callee-save in Microsoft 64-bit ABI, but not in AMD64 ABI.
-  __ pop(rsi);
-#endif
+  // Return a random uint32 number in rax.
+  // The fresh HeapNumber is in rbx, which is callee-save on both x64 ABIs.
+  __ PrepareCallCFunction(0);
+  __ CallCFunction(ExternalReference::random_uint32_function(), 0);
+
+  // Convert 32 random bits in eax to 0.(32 random bits) in a double
+  // by computing:
+  // ( 1.(20 0s)(32 random bits) x 2^20 ) - (1.0 x 2^20)).
+  __ movl(rcx, Immediate(0x49800000));  // 1.0 x 2^20 as single.
+  __ movd(xmm1, rcx);
+  __ movd(xmm0, rax);
+  __ cvtss2sd(xmm1, xmm1);
+  __ xorpd(xmm0, xmm1);
+  __ subsd(xmm0, xmm1);
+  __ movsd(FieldOperand(rbx, HeapNumber::kValueOffset), xmm0);
+
+  __ movq(rax, rbx);
   Result result = allocator_->Allocate(rax);
   frame_->Push(&result);
 }
 
 
 void CodeGenerator::GenerateRegExpExec(ZoneList<Expression*>* args) {
   ASSERT_EQ(args->length(), 4);
 
   // Load the arguments on the stack and call the runtime system.
   Load(args->at(0));
@@ skipping 5951 matching lines @@
   // Call the function from C++.
   return FUNCTION_CAST<ModuloFunction>(buffer);
 }
 
 #endif
 
 
 #undef __
 
 } }  // namespace v8::internal