src/ic.cc - Issue 1629008: Re-submitting binary op ICs for ARM. Does not break debug tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 1629008: Re-submitting binary op ICs for ARM. Does not break debug tests (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

===================================================================

--- src/ic.cc (revision 4363)

+++ src/ic.cc (working copy)

@@ -1433,8 +1433,9 @@

BinaryOpIC::TypeInfo BinaryOpIC::GetTypeInfo(Object* left,

Object* right) {

- // Patching is never requested for the two smis.

- ASSERT(!left->IsSmi() || !right->IsSmi());

+ if (left->IsSmi() && right->IsSmi()) {

+ return GENERIC;

+ }

if (left->IsNumber() && right->IsNumber()) {

return HEAP_NUMBERS;

« no previous file with comments | « src/arm/codegen-arm.cc ('k') | no next file » | no next file with comments »