Issue 1629008: Re-submitting binary op ICs for ARM. Does not break debug tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1629008: Re-submitting binary op ICs for ARM. Does not break debug tests (Closed)

Created:
10 years, 8 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Re-submitting binary op ICs for ARM. Does not break debug tests now. Committed: http://code.google.com/p/v8/source/detail?r=4365

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+345 lines, -253 lines)			Patch
M	src/arm/codegen-arm.h	View	3 chunks	+48 lines, -3 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	6 chunks	+294 lines, -248 lines	0 comments	Download
M	src/ic.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Mads Ager (chromium)

10 years, 8 months ago (2010-04-08 15:12:42 UTC) #2

LGTM, I suppose the only change to the previous submit is the removal of the
clearing on GC?