Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1629005: Revert 43826 - HostResolver now adds AI_CANONNAME to the hint flags if a requ... (Closed)

Created:
10 years, 8 months ago by cbentzel
Modified:
9 years, 7 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 43826 - HostResolver now adds AI_CANONNAME to the hint flags if a requester needs the information. Requests which want the canonical name should be treated differently from requests that do not for the same host in both the HostCache as well as in the HostResolver when combining multiple outstanding requests into a job. The motivation for this is that Kerberos SPN's for a web server are typically generated using the canonical name of the server rather than a DNS alias (both Firefox and IE have this behavior). BUG=29862 TEST=net_unittests Review URL: http://codereview.chromium.org/1566012 TBR=cbentzel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -255 lines) Patch
M chrome/browser/intranet_redirect_detector.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/net/view_net_internals_job_factory.cc View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/test/unit/chrome_test_suite.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/base/address_family.h View 2 chunks +2 lines, -9 lines 0 comments Download
M net/base/address_list.h View 2 chunks +1 line, -10 lines 0 comments Download
M net/base/address_list.cc View 2 chunks +1 line, -9 lines 0 comments Download
M net/base/address_list_unittest.cc View 5 chunks +8 lines, -62 lines 0 comments Download
M net/base/host_cache.h View 2 chunks +8 lines, -15 lines 0 comments Download
M net/base/host_cache_unittest.cc View 5 chunks +16 lines, -71 lines 0 comments Download
M net/base/host_resolver.h View 3 chunks +0 lines, -11 lines 0 comments Download
M net/base/host_resolver_impl.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M net/base/host_resolver_impl_unittest.cc View 6 chunks +3 lines, -10 lines 0 comments Download
M net/base/host_resolver_proc.h View 3 chunks +0 lines, -3 lines 0 comments Download
M net/base/host_resolver_proc.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M net/base/mock_host_resolver.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/base/mock_host_resolver.cc View 4 chunks +3 lines, -9 lines 0 comments Download
M net/proxy/proxy_resolver_js_bindings_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
cbentzel
10 years, 8 months ago (2010-04-07 14:41:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698