Issue 1627003: Move createApplicationCacheHost from WebKitClient to WebFrameClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1627003: Move createApplicationCacheHost from WebKitClient to WebFrameClient. (Closed)

Created:
10 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
michaeln, darin (slow to review)

CC:
chromium-reviews, jam+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Move createApplicationCacheHost from WebKitClient to WebFrameClient. This patch prepares chromium for the WebKit side patch so build doesn't break: https://bugs.webkit.org/show_bug.cgi?id=36882 BUG=38362 TEST=none

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -0 lines)			Patch
M	chrome/renderer/render_view.h	View	2 chunks	+4 lines, -0 lines	1 comment	Download
M	chrome/renderer/render_view.cc	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.h	View	1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

michaeln

10 years, 8 months ago (2010-04-06 18:52:15 UTC) #2

http://codereview.chromium.org/1627003/diff/1/3
File chrome/renderer/render_view.h (right):

http://codereview.chromium.org/1627003/diff/1/3#newcode137
chrome/renderer/render_view.h:137: public WebKit::WebFrameClient,
You'll also want to add the new factory method for test_shell, see...

test_shell/test_webview_delegate.h  // WebFrameClient
test_shell/test_shell_webkit_init.h  // WebKitClient

http://codereview.chromium.org/1627003/diff/1/4
File webkit/glue/webkitclient_impl.h (right):

http://codereview.chromium.org/1627003/diff/1/4#newcode19
webkit/glue/webkitclient_impl.h:19: class WebApplicationCacheHostClient;
why are these needed?

Expand Messages | Collapse Messages