Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4180)

Unified Diff: build/linux/dump_app_syms

Issue 1627001: Linux: simplify dump_app_syms since newer versions of Breakpad no longer gene... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/linux/dump_app_syms
===================================================================
--- build/linux/dump_app_syms (revision 43673)
+++ build/linux/dump_app_syms (working copy)
@@ -1,11 +1,11 @@
#!/bin/sh
-# Copyright (c) 2009 The Chromium Authors. All rights reserved.
+# Copyright (c) 2010 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
#
-# Helper script to run dump_syms on Chrome Linux executables and "fixup" the
-# generated sigs (due to changes to the binary from stripping).
+# Helper script to run dump_syms on Chrome Linux executables and strip
+# them if needed.
set -e
@@ -22,29 +22,15 @@
SCRIPTDIR="$(readlink -f "$(dirname "$0")")"
DUMPSYMS="$1"
-KEEP_STRIPPED_BINARY="$2"
+STRIP_BINARY="$2"
INFILE="$3"
OUTFILE="$4"
-STRIPPED=$(mktemp -q -t stripped-XXXXX)
-if [ $? -ne 0 ]; then
- echo "ERROR: Could not create temp stripped '$INFILE'" >&2
- exit 1
-fi
-
# Dump the symbols from the given binary.
if [ ! -e "$OUTFILE" -o "$INFILE" -nt "$OUTFILE" ]; then
"$DUMPSYMS" "$INFILE" > "$OUTFILE"
fi
-# Strip the binary and calculate the signature of that, since that's what ships.
-strip "$INFILE" -o "$STRIPPED"
-NEWSIG=$("$SCRIPTDIR/dump_signature.py" "$STRIPPED")
-if [ "$KEEP_STRIPPED_BINARY" != "0" ]; then
- mv "$STRIPPED" "$INFILE"
-else
- rm "$STRIPPED"
+if [ "$STRIP_BINARY" != "0" ]; then
+ strip "$INFILE"
fi
-
-# Replace the old signature with the stripped signature in the symbols file.
-sed -i "1s/ [0-9A-F]* / $NEWSIG /" "$OUTFILE"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698