Issue 16263: Make Skia build as a dynamic library by fixing up the imports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16263: Make Skia build as a dynamic library by fixing up the imports. (Closed)

Created:
11 years, 12 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
brettw, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make Skia build as a dynamic library by fixing up the imports. The define in the SCons file / vsprops was unused in the Skia source; I imagine usage of it was removed in the recent Skia merge.

Patch Set 1 #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	skia/SConscript	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	skia/ports/SkImageDecoder_Factory.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	skia/skia.vsprops	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages