Issue 16252: Reverting 7423.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16252: Reverting 7423. (Closed)

Created:
12 years ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
erikkay

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Avi (use Gerrit)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting 7423. After talking with Darin, I'm convinced this was a bad idea. The issue is that Linux can't actually know the encoding of the file (bad Linux!), so on Linux this method is nonsensical. It also turns out to not be useful for the case I thought I needed it for. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7455

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -13 lines)			Patch
	M	base/file_path.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	base/file_path.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages