Add a method to explicitly request a UTF8 representation of a FilePath. This...

Add a method to explicitly request a UTF8 representation of a FilePath.  This is for places where you need to use a FilePath in a non-filesystem context (for example, adding a file to an archive file, or constructing a file:// URL).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7423

[Avi (use Gerrit), 2008-12-23 18:35:45]

lgtm!

I can think of a few place I could use something like this...

[darin (slow to review), 2008-12-23 20:23:55]

http://codereview.chromium.org/16239/diff/1/2
File base/file_path.cc (right):

http://codereview.chromium.org/16239/diff/1/2#newcode68
Line 68: // TODO(erikkay): I'm not sure how to make this code always correct for
Linux.
this is precisely why this kind of function is problematic / evil.  why do we
need a UTF8Value accessor?

if you need to store UTF8 representations, then maybe you should convert to a
file:// URL where we have an escaping mechanism to deal with non-UTF8 code
points.

[Avi (use Gerrit), 2008-12-23 22:58:49]

http://codereview.chromium.org/16239/diff/1/2
File base/file_path.cc (right):

http://codereview.chromium.org/16239/diff/1/2#newcode68
Line 68: // TODO(erikkay): I'm not sure how to make this code always correct for
Linux.
On 2008/12/23 20:23:55, darin wrote:
> why do we
> need a UTF8Value accessor?

There are cases where we need to have the path in one format across all
platforms. The example I just hit was converting to a WebCore::PluginInfo, which
takes a String.

[Erik does not do reviews, 2008-12-23 23:02:04]

http://codereview.chromium.org/16239/diff/1/2
File base/file_path.cc (right):

http://codereview.chromium.org/16239/diff/1/2#newcode68
Line 68: // TODO(erikkay): I'm not sure how to make this code always correct for
Linux.
On 2008/12/23 22:58:49, Avi wrote:
> On 2008/12/23 20:23:55, darin wrote:
> > why do we
> > need a UTF8Value accessor?
> 
> There are cases where we need to have the path in one format across all
> platforms. The example I just hit was converting to a WebCore::PluginInfo,
which
> takes a String.

Unfortunately, as Darin educated me here, this method can't actually work on
Linux.  Since from the Linux perspective, it doesn't actually know what the
filesystem encoding is for a given filename, asking it to convert to UTF8 is
nonsensical.  I'm about to revert this CL.