Issue 1622015: Fix build image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1622015: Fix build image (Closed)

Created:
10 years, 8 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
seano, adlr

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Fix build image

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/scripts/build_image	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

sosa

-n doesn't work since you are setting a default value of flags_false. Since you didn't ...

10 years, 8 months ago (2010-04-09 03:34:37 UTC) #1

adlr

I talked to chris. I'm going to fix this myself and send him a review.

10 years, 8 months ago (2010-04-09 03:40:33 UTC) #2

sosa

10 years, 8 months ago (2010-04-09 03:52:32 UTC) #4

pushed.

On Thu, Apr 8, 2010 at 8:51 PM,  <adlr@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/1622015/show
>