Issue 1621007: Build selenium tests on the bots. This test is running on the webkit.org xp ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1621007: Build selenium tests on the bots. This test is running on the webkit.org xp ... (Closed)

Created:
10 years, 8 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Build selenium tests on the bots. This test is running on the webkit.org xp perf bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43918

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ojan

10 years, 8 months ago (2010-04-08 00:46:47 UTC) #2

LGTM

On Wed, Apr 7, 2010 at 5:41 PM, <nsylvain@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Build selenium tests on the bots.  This test is running on the webkit.orgxp
> perf bot.
>
>
> Please review this at http://codereview.chromium.org/1621007/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     build/all.gyp
>
>
> Index: build/all.gyp
> ===================================================================
> --- build/all.gyp       (revision 43898)
> +++ build/all.gyp       (working copy)
> @@ -202,6 +202,7 @@
>             '../chrome/chrome.gyp:nacl_ui_tests',
>             '../chrome/chrome.gyp:page_cycler_tests',
>             '../chrome/chrome.gyp:plugin_tests',
> +            '../chrome/chrome.gyp:selenium_tests',
>             '../chrome/chrome.gyp:startup_tests',
>             '../chrome/chrome.gyp:sync_unit_tests',
>             '../chrome/chrome.gyp:tab_switching_test',
>
>
>

Expand Messages | Collapse Messages