Issue 162007: Fix the debugger in multipass mode by introducing phantome...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 162007: Fix the debugger in multipass mode by introducing phantome... (Closed)

Created:
11 years, 4 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix the debugger in multipass mode by introducing phantom instructions marking statement boundaries. Committed: http://code.google.com/p/v8/source/detail?r=2633

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -5 lines)			Patch
M	src/arm/cfg-arm.cc	View	1 2 3	1 chunk	+8 lines, -0 lines	1 comment	Download
M	src/cfg.h	View	1	3 chunks	+28 lines, -5 lines	0 comments	Download
M	src/cfg.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/ia32/cfg-ia32.cc	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/x64/cfg-x64.cc	View	1 2 3	1 chunk	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

You can safely ignore the part of this (expression statements) that overlaps with the other ...

11 years, 4 months ago (2009-08-05 15:18:07 UTC) #1

Lasse Reichstein

11 years, 4 months ago (2009-08-06 10:02:28 UTC) #3

LGTM

http://codereview.chromium.org/162007/diff/2014/3012
File src/arm/cfg-arm.cc (right):

http://codereview.chromium.org/162007/diff/2014/3012#newcode105
Line 105: __ RecordStatementPosition(pos_);
Should we use "masm->" instead of "__" here? Using "__" might add extra coverage
code.

http://codereview.chromium.org/162007/diff/2014/3010
File src/x64/cfg-x64.cc (right):

http://codereview.chromium.org/162007/diff/2014/3010#newcode129
Line 129: __ RecordPosition(pos_);
These functions are all identical, and uses only generic MacroAssembler
functionality. There shouldn't need to be three of them.

Expand Messages | Collapse Messages