Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 162006: Added support for expression statements to the CFG builder and... (Closed)

Created:
11 years, 4 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added support for expression statements to the CFG builder and fast-mode compiler. This will generate a compiler temporary for complex expressions and then immediately throw it away, so a better approach (to be implemented later) is to pass to the expression builder whether an expression is in an effect or value context. Committed: http://code.google.com/p/v8/source/detail?r=2630

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M src/cfg.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/cfg.cc View 1 chunk +13 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 4 months ago (2009-08-05 13:35:40 UTC) #1
Kevin Millikin (Chromium)
Lasse, do you have time to review this?
11 years, 4 months ago (2009-08-06 07:21:58 UTC) #2
Lasse Reichstein
11 years, 4 months ago (2009-08-06 07:42:33 UTC) #3
LGTM

http://codereview.chromium.org/162006/diff/1/3
File src/cfg.cc (right):

http://codereview.chromium.org/162006/diff/1/3#newcode439
Line 439: cfg_->Concatenate(builder.cfg());
Call it graph_ or flow_graph_ or even control_flow_graph_.

Powered by Google App Engine
This is Rietveld 408576698