Issue 1619023: Fix 2 drag-out problems:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1619023: Fix 2 drag-out problems:... (Closed)

Created:
10 years, 8 months ago by jianli

Modified:
9 years, 6 months ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews, ben+cc_chromium.org, dcheng

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix 2 drag-out problems: 1) Does not work if dragging out to XP desktop. We need to return an error code when waiting for XP Shell to start a background thread. 2) Occasional crash due to regression caused by r43726. Fix it by holding a local reference to drag_source_. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44833

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
	M	app/os_exchange_data_provider_win.cc	View		1 chunk	+16 lines, -15 lines	0 comments	Download
	M	chrome/browser/views/tab_contents/tab_contents_drag_win.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages