Issue 1619018: monitor_reconfigure: Clean up build and style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1619018: monitor_reconfigure: Clean up build and style. (Closed)

Created:
10 years, 8 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone, sosa

CC:
chromium-os-reviews_chromium.org, sosa

Visibility:
Public.

Description

monitor_reconfigure: Clean up build and style. BUG=none TEST=built it

Patch Set 1 #

Patch Set 2 : update header guard name #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -88 lines)			Patch
M	src/platform/monitor_reconfig/Makefile	View		1 chunk	+18 lines, -18 lines	0 comments	Download
M	src/platform/monitor_reconfig/README	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/platform/monitor_reconfig/monitor_reconfigure_main.h	View	1	2 chunks	+20 lines, -14 lines	0 comments	Download
M	src/platform/monitor_reconfig/monitor_reconfigure_main.cc	View	1	6 chunks	+64 lines, -54 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

chris directives: sosa: review code masone: review makefile (I based it on the login manager ...

10 years, 8 months ago (2010-04-14 16:51:09 UTC) #1

Chris Masone

On 2010/04/14 16:51:09, Daniel Erat wrote: > chris directives: > > sosa: review code > ...

10 years, 8 months ago (2010-04-14 17:03:18 UTC) #2

sosa

10 years, 8 months ago (2010-04-14 17:20:33 UTC) #3

LGTM, nice cleanup.  I had hoped to add more logging myself but didn't want to
add base back in the day.  Thanks.

http://codereview.chromium.org/1619018/diff/2001/3003
File src/platform/monitor_reconfig/monitor_reconfigure_main.cc (right):

http://codereview.chromium.org/1619018/diff/2001/3003#newcode55
src/platform/monitor_reconfig/monitor_reconfigure_main.cc:55: for (int i = 0; i
< output->nmode; ++i) {
you don't like m's :)?

Expand Messages | Collapse Messages