Issue 1619005: Allow the existence of ~/.gcl_upload_no_try override the default of try on up...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1619005: Allow the existence of ~/.gcl_upload_no_try override the default of try on up... (Closed)

Created:
10 years, 8 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Allow the existence of ~/.gcl_upload_no_try override the default of try on upload. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43854

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -8 lines)			Patch
	M	gcl.py	View		3 chunks	+19 lines, -1 line	0 comments	Download
	M	tests/gcl_unittest.py	View	3	6 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Don't you think it'd be nicer to have it per checkout? I'm just wondering, maybe ...

10 years, 8 months ago (2010-04-07 17:40:02 UTC) #2

TVL

On 2010/04/07 17:40:02, Marc-Antoine Ruel wrote: > Don't you think it'd be nicer to have ...

10 years, 8 months ago (2010-04-07 17:49:16 UTC) #3

M-A Ruel

10 years, 8 months ago (2010-04-07 17:55:53 UTC) #4

On 2010/04/07 17:49:16, TVL wrote:
> On 2010/04/07 17:40:02, Marc-Antoine Ruel wrote:
> > Don't you think it'd be nicer to have it per checkout?
> > 
> > I'm just wondering, maybe no one cares.
> 
> I debated that, but since the only real option is GetRepositoryRoot() and a
> single checkout has a few of those, I wasn't sure what to do?  Should I dup
the
> logic from gclient.py that walks up looking for a .gclient file and use that? 
> or should we support this file in $HOME and in GetRepositoryRoot()

In fact you want GetInfoDir(), it returns .svn/gcl_info/ and you can add stuff
there, there's already 2 directories.

I understand people may prefer to just disable that globally though. So I don't
really mind.

lgtm this way.

Expand Messages | Collapse Messages