Issue 1618004: Install xml files so they can be used by cromo (chromeos modem manager)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1618004: Install xml files so they can be used by cromo (chromeos modem manager) (Closed)

Created:
10 years, 8 months ago by Jason Glasgow

Modified:
9 years, 7 months ago

Reviewers:
Eric Shienbrood

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Install xml files so they can be used by cromo (chromeos modem manager)

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
		Makefile.am	View		1 chunk	+3 lines, -0 lines	1 comment	Download
		introspection/mm-modem-cdma.xml	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jason Glasgow

Here are some changes so we can build cromo based on the mdoem manager XML ...

10 years, 8 months ago (2010-04-06 20:46:06 UTC) #1

Eric Shienbrood

http://codereview.chromium.org/1618004/diff/1/2 File Makefile.am (right): http://codereview.chromium.org/1618004/diff/1/2#newcode44 Makefile.am:44: Does xml_DATA need to be added to EXTRA_DIST?

10 years, 8 months ago (2010-04-06 21:37:35 UTC) #2

Jason Glasgow

I think these do not need to be on EXTRA_DIST, because the are actually installed ...

10 years, 8 months ago (2010-04-07 18:08:40 UTC) #3

LGTM

Expand Messages | Collapse Messages