Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1617013: Prevent people from adding mime type to supported_non_image_types that will m... (Closed)

Created:
10 years, 8 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Prevent people from adding mime type to supported_non_image_types that will make it render as HTML. This is not the fix for bug, but to prevent people from making the same mistake again. BUG=38105 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44143

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/base/mime_util.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
inferno
This comment will go on the chromium side. Webkit fix+comments will go in the webkit ...
10 years, 8 months ago (2010-04-09 17:09:27 UTC) #1
abarth-chromium
Ideally, we'd have a DCHECK. Can we just DCHECK the size of the array somewhere ...
10 years, 8 months ago (2010-04-09 20:44:40 UTC) #2
inferno
Done. Does that look ok. i will do the same in webkit one too.
10 years, 8 months ago (2010-04-09 21:08:54 UTC) #3
abarth-chromium
Those patches look good, but can we have both? The goal of the assert is ...
10 years, 8 months ago (2010-04-09 21:31:29 UTC) #4
inferno
10 years, 8 months ago (2010-04-09 22:27:56 UTC) #5
Done and commited.

Powered by Google App Engine
This is Rietveld 408576698