Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1617004: Add chromeos site-specific test importer wrappers. (Closed)

Created:
10 years, 8 months ago by truty
Modified:
9 years, 4 months ago
Reviewers:
ericli
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, petkov+cc_chromium.org
Visibility:
Public.

Description

Add chromeos site-specific test importer wrappers. Adjust tests available in Autotest slightly. Also we display the test dirname in the Autotest UI instead of the control file text. People seem to think the dirname is easier to remember.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Tidy up a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
A utils/site_test_importer.sh View 1 1 chunk +22 lines, -0 lines 0 comments Download
A utils/site_test_importer_attributes.py View 1 1 chunk +25 lines, -0 lines 0 comments Download
A utils/site_whitelist_tests View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
truty
Let's add our site-specific test importer wrappers.
10 years, 8 months ago (2010-04-05 20:53:09 UTC) #1
ericli
http://codereview.chromium.org/1617004/diff/1/2 File utils/site_test_importer.sh (right): http://codereview.chromium.org/1617004/diff/1/2#newcode8 utils/site_test_importer.sh:8: # It is a customization on utils/test_importer.py. I dont ...
10 years, 8 months ago (2010-04-05 21:06:10 UTC) #2
truty
Fixed http://codereview.chromium.org/1617004/diff/1/2 File utils/site_test_importer.sh (right): http://codereview.chromium.org/1617004/diff/1/2#newcode8 utils/site_test_importer.sh:8: # It is a customization on utils/test_importer.py. On ...
10 years, 8 months ago (2010-04-05 21:14:20 UTC) #3
ericli
10 years, 8 months ago (2010-04-05 21:21:16 UTC) #4
LGTM.

On 2010/04/05 21:14:20, truty wrote:
> Fixed
> 
> http://codereview.chromium.org/1617004/diff/1/2
> File utils/site_test_importer.sh (right):
> 
> http://codereview.chromium.org/1617004/diff/1/2#newcode8
> utils/site_test_importer.sh:8: # It is a customization on
> utils/test_importer.py.
> On 2010/04/05 21:06:12, ericli wrote:
> > I dont think this comment is necessary.
> 
> Done.
> 
> http://codereview.chromium.org/1617004/diff/1/3
> File utils/site_test_importer_attributes.py (right):
> 
> http://codereview.chromium.org/1617004/diff/1/3#newcode10
> utils/site_test_importer_attributes.py:10: import common
> On 2010/04/05 21:06:12, ericli wrote:
> > put import in one line.
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698