Flush socket pools and SPDY session pool properly on explicit requests and network changes.

Flush socket pools and SPDY session pool properly on explicit requests and network changes.
BUG=40455, 40457
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43908

[Mike Belshe, 2010-04-06 19:53:45]

lgtm

http://codereview.chromium.org/1615005/diff/1/5
File net/http/http_network_session.cc (right):

http://codereview.chromium.org/1615005/diff/1/5#newcode40
net/http/http_network_session.cc:40: spdy_session_pool_(new SpdySessionPool()),
nit:  stylistically, you could do a CreateNewSpdySessionPool() to match the
above, but don't feel you have to do this.

http://codereview.chromium.org/1615005/diff/1/16
File net/socket/tcp_client_socket_pool_unittest.cc (left):

http://codereview.chromium.org/1615005/diff/1/16#oldcode631
net/socket/tcp_client_socket_pool_unittest.cc:631:
TEST_F(TCPClientSocketPoolTest, ResetIdleSocketsOnIPAddressChange) {
I guess there are no NetworkSession tests where we can re-add this test?

[willchan no longer on Chromium, 2010-04-07 23:36:09]

I've added support for flushing HostResolver too.  All the flushing logic for
the network stack objects is contained in HttpNetworkSession now.  Please take
another look.

http://codereview.chromium.org/1615005/diff/1/16
File net/socket/tcp_client_socket_pool_unittest.cc (left):

http://codereview.chromium.org/1615005/diff/1/16#oldcode631
net/socket/tcp_client_socket_pool_unittest.cc:631:
TEST_F(TCPClientSocketPoolTest, ResetIdleSocketsOnIPAddressChange) {
On 2010/04/06 19:53:45, Mike Belshe wrote:
> I guess there are no NetworkSession tests where we can re-add this test?

I've added such a test over there.

[Mike Belshe, 2010-04-08 00:45:36]

lgtm!