Issue 1614001: Pull latest googleurl to get it to stop unescaping at signs in paths....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1614001: Pull latest googleurl to get it to stop unescaping at signs in paths.... (Closed)

Created:
10 years, 8 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Pull latest googleurl to get it to stop unescaping at signs in paths. This also fixes the URL displayer to stop unescaping at signs. Otherwise, we'll have the weird situation where if you go to a site with a %40 in it where it cares about the difference between %40 and @, pressing enter in the URL bar will load the "@" variant and the URL won't load. BUG=http:///crbug.com/23933 TEST=included unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43615

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/escape.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/escape_unittest.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/base/net_util.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/base/net_util_unittest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

I added some changes to net_util to keep this from breaking tests. The problem was ...

10 years, 8 months ago (2010-04-02 19:22:20 UTC) #3

eroman

10 years, 8 months ago (2010-04-02 22:44:36 UTC) #4

lgtm on the new changes.
thanks for fixing my omission of special chars in net_util!

Expand Messages | Collapse Messages