Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1613024: Removed NOTIMPLEMENTED() from Encryptor::EncryptString() and Encryptor::Decry... (Closed)

Created:
10 years, 8 months ago by GeorgeY
Modified:
9 years, 6 months ago
Reviewers:
stuartmorgan, dhollowa
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Removed NOTIMPLEMENTED() from Encryptor::EncryptString() and Encryptor::DecryptString() in chrome/browser/password_manager/encryptor_mac.mm, so it does exactly the same thing as on Linux: copies unencrypted text. BUG=25404 TEST=Filling out Autofill for CC on Mac should not assert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/password_manager/encryptor_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
GeorgeY
10 years, 8 months ago (2010-04-19 22:11:36 UTC) #1
dhollowa
LGTM.
10 years, 8 months ago (2010-04-19 22:19:20 UTC) #2
stuartmorgan
For the reasons explained in http://crbug.com/42038 I think this is moving us in the wrong ...
10 years, 8 months ago (2010-04-20 00:19:31 UTC) #3
stuartmorgan
10 years, 8 months ago (2010-04-20 00:21:53 UTC) #4
(To be clear, I understand that from the comments in the files it seems like a
perfectly reasonable change, I just don't think those comments reflect the
reality of where we should be going.)

Powered by Google App Engine
This is Rietveld 408576698