Reimplement InsertSort to use simple linear search.

Reimplement InsertSort to use simple linear search.

And various minor cleanups.

Committed: http://code.google.com/p/v8/source/detail?r=4392

[antonm, 2010-04-12 07:13:36]

Lasse, promised cleanup and simplification.

May you have a look?

[Lasse Reichstein, 2010-04-12 07:35:42]

LGTM

http://codereview.chromium.org/1611021/diff/1/2
File src/array.js (right):

http://codereview.chromium.org/1611021/diff/1/2#newcode715
src/array.js:715: var key = %_IsSmi(element) ? element : ToString(element);
I'm very much attached to this line, but on the other hand, the most common uses
of sort-with-default-comparison is on numbers and strings, so it might just be
overhead.

Keep it, but maybe try a test run later without this line and see if it makes a
difference in any direction.

[antonm, 2010-04-12 15:24:25]

Thanks a lot for review, Lasse.

http://codereview.chromium.org/1611021/diff/1/2
File src/array.js (right):

http://codereview.chromium.org/1611021/diff/1/2#newcode715
src/array.js:715: var key = %_IsSmi(element) ? element : ToString(element);
On 2010/04/12 07:35:42, Lasse Reichstein wrote:
> I'm very much attached to this line, but on the other hand, the most common
uses
> of sort-with-default-comparison is on numbers and strings, so it might just be
> overhead.
> 
> Keep it, but maybe try a test run later without this line and see if it makes
a
> difference in any direction.

Sure.  Sending to golem in no time.