Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2211)

Unified Diff: chrome/browser/cocoa/toolbar_controller_unittest.mm

Issue 1608001: [Mac] Line up omnibox popup under field. (Closed)
Patch Set: Wordsmith and test fix. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/toolbar_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/toolbar_controller_unittest.mm
diff --git a/chrome/browser/cocoa/toolbar_controller_unittest.mm b/chrome/browser/cocoa/toolbar_controller_unittest.mm
index dab5cba344d639eea3d86810442f52592ece80f7..8dcb13570b942ac07055aaab4052c4c1d78cb32f 100644
--- a/chrome/browser/cocoa/toolbar_controller_unittest.mm
+++ b/chrome/browser/cocoa/toolbar_controller_unittest.mm
@@ -240,10 +240,10 @@ TEST_F(ToolbarControllerTest, BubblePosition) {
// coordinates here are used for the omnibox dropdown.
gfx::Rect locationStackFrame = [bar_ locationStackBounds];
- // Make sure the location stack starts to the left of and ends to the right of
- // the location bar.
- EXPECT_LT(locationStackFrame.x(), NSMinX(locationFrame));
- EXPECT_GT(locationStackFrame.right(), NSMaxX(locationFrame));
+ // The location stack should be just within the border of the
+ // location bar.
+ EXPECT_EQ(locationStackFrame.x(), NSMinX(locationFrame) + 1);
+ EXPECT_EQ(locationStackFrame.right(), NSMaxX(locationFrame) - 1);
}
TEST_F(ToolbarControllerTest, HoverButtonForEvent) {
« no previous file with comments | « chrome/browser/cocoa/toolbar_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698