presubmit_canned_checks.py - Issue 160626: Use input_api.os_path.pathsep instead of ';' to join a list of paths....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 160626: Use input_api.os_path.pathsep instead of ';' to join a list of paths.... (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

===================================================================

--- presubmit_canned_checks.py (revision 22355)

+++ presubmit_canned_checks.py (working copy)

@@ -284,10 +284,10 @@

cwd = input_api.os_path.dirname(unit_test)

unit_test = input_api.os_path.basename(unit_test)

env = input_api.environ.copy()

- backpath = [';'.join(['..'] * (cwd.count('/') + 1))]

+ backpath = [input_api.os_path.pathsep.join(['..'] * (cwd.count('/') + 1))]

if env.get('PYTHONPATH'):

backpath.append(env.get('PYTHONPATH'))

- env['PYTHONPATH'] = ';'.join((backpath))

+ env['PYTHONPATH'] = input_api.os_path.pathsep.join((backpath))

subproc = input_api.subprocess.Popen(

[

input_api.python_executable,

« no previous file with comments | « no previous file | no next file » | no next file with comments »