Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 160610: Make extensions in the extension shelf render their content to a visible GTK (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make extensions in the extension shelf render their content to a visible GTK widget. TEST=none http://crbug.com/16759 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22439

Patch Set 1 #

Patch Set 2 : initialize is_toolstrip_ #

Patch Set 3 : should be initialized to true to match Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M chrome/browser/extensions/extension_host.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/gtk/extension_shelf_gtk.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M chrome/browser/gtk/extension_view_gtk.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/gtk/extension_view_gtk.cc View 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
11 years, 4 months ago (2009-08-04 22:48:35 UTC) #1
Aaron Boodman
11 years, 4 months ago (2009-08-04 22:55:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698