src/platform-posix.cc - Issue 160580: Add safe handling of NaN to Posix platform-dependent time functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform-posix.cc

Issue 160580: Add safe handling of NaN to Posix platform-dependent time functions. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/platform-posix.cc

===================================================================

--- src/platform-posix.cc (revision 2614)

+++ src/platform-posix.cc (working copy)

@@ -87,7 +87,7 @@

const char* OS::LocalTimezone(double time) {

- ASSERT(!isnan(time));

+ if (isnan(time)) return "";

time_t tv = static_cast<time_t>(floor(time/msPerSecond));

struct tm* t = localtime(&tv);

if (NULL == t) return "";

@@ -96,7 +96,7 @@

double OS::DaylightSavingsOffset(double time) {

- ASSERT(!isnan(time));

+ if (isnan(time)) return nan_value();

time_t tv = static_cast<time_t>(floor(time/msPerSecond));

struct tm* t = localtime(&tv);

if (NULL == t) return nan_value();

« no previous file with comments | « src/date-delay.js ('k') | test/mjsunit/regress/regress-416.js » ('j') | no next file with comments »