Move the entire application into a dylib (framework)

Move the entire application into a dylib (framework)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22506

[Mark Mentovai, 2009-08-03 21:10:07]

Early version.  Tomorrow I'll try it out with a branded build to check the
breakpads and rotors.

[TVL, 2009-08-04 04:10:18]

make sure you try clean builds of the unittests since there have been linking
issues in the past with breakpad/keystone bits.

http://codereview.chromium.org/160538/diff/1/3
File build/mac/dump_app_syms (right):

http://codereview.chromium.org/160538/diff/1/3#newcode40
Line 40: # Do chrome_dll symbols too
is this a todo?

http://codereview.chromium.org/160538/diff/1/4
File chrome/app/chrome_dll_main.cc (right):

http://codereview.chromium.org/160538/diff/1/4#newcode316
Line 316: #endif  // OS_MACOSX
why endif mac ad start another one 2 lines later?

http://codereview.chromium.org/160538/diff/1/6
File chrome/chrome.gyp (right):

http://codereview.chromium.org/160538/diff/1/6#newcode4406
Line 4406: 'product_name': 'Chrome',
should we give up and move this into common.gypi so it's usable in more places?
(and the breakpad and keystone flags)

http://codereview.chromium.org/160538/diff/1/6#newcode4446
Line 4446: },
a few more comments on what major ones here are closing?

http://codereview.chromium.org/160538/diff/1/6#newcode4468
Line 4468: # completely replace "package_app").
actually, this comment is stale, it is only here if someone wants it, we don't
use it in any of our builds (buildbot or official).

[Mark Mentovai, 2009-08-04 21:34:24]

Time for another look.

I've addressed the comments and have extended this to work properly with
official release Chrome-branded builds.

I'm still going to give this a try with a cleaner build and some tests.

[TVL, 2009-08-05 15:02:02]

lg

[Mark Mentovai, 2009-08-05 19:14:04]

One more look?  I needed to add STRIPFLAGS to common.gypi.

[TVL, 2009-08-05 19:23:21]

slg